Conversation
riasvdv
approved these changes
Nov 14, 2025
Ran into performance issues due to the number of items in the locales list
This modal will eventually get refactored into the @craftcms/cp package
brianjhanson
commented
Nov 18, 2025
| import '../option/option.js'; | ||
| import '../icon/icon.js'; | ||
|
|
||
| export default class CraftSelect extends LionSelectRich { |
Contributor
Author
There was a problem hiding this comment.
I had originally planned to use the Rich Select for everything in the CP, but ran into performance issues when rendering the number of options for the site locale.
Contributor
Author
There was a problem hiding this comment.
@riasvdv I think this is because of the rector rules. I forget, is this what we want?
Contributor
There was a problem hiding this comment.
Yes but we should just import it at the top 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Biting off a bit less than #18005 — moves the installer to Inertia. Still a lot of plumbing included in this one, but an easier first step.
Nothing super notable changed in the process the installer (for now) still behaves like you know and love.
This isn't even super inertia powered because Inertia doesn't really love multi-step forms that all appear on the same page.
In the future we might want to refactor this to be separate pages while keeping track of where a user is in the session, but that's for another day.
CleanShot.2025-11-18.at.14.07.51.mp4
This PR does not have an autocomplete component for the Site URL because we haven't built that component yet and it's a bit more complex than I wanted for this PR.
This also doesn't include Playwright tests because those seem to be broken in 6.x at the moment, going to be looking into that soon.